[HTML/PHP] Pop-ups & forms

guar · June 2009

Would that go in index.php, which calls delete.php, or in delete.php ?

Infidel · June 2009

That would go wherever you want when you need to redirect, instead of printing HTML.

Depends on how you designed your code! :lol:

edit: here's the general form of having a one-shot form/post window,

if (isset($_POST['submit']))
{
    // do my deleting in the database here
    // then HTTP redirect to the window close
    header('Location: closewin.html');
}
else
{
?>
<html>
...
<form method="post">
<input name="submit" type="submit" value="Delete">
</form>
...
</html>
<?
}

guar · June 2009

Maybe I'm not understanding, but to illustrate:

delete.php

<?php
    header('Location: http://localhost/index.php');

    $link = mysql_connect('localhost', 'root', '******');
    $db = mysql_select_db('backlog');

    $table = sprintf("&#37;s", mysql_real_escape_string($_GET[table]));
    $id = sprintf("%s", mysql_real_escape_string($_GET[id]));;

    mysql_query("DELETE FROM $table WHERE id = $id");

    mysql_close($link);
?>

Seguer · June 2009

In the page that you submit the form to you can have that close the window.

So if update.php submits to itself and you have code that checks for a form submission, once you've done all the updates you just echo html that will close that window instead of redirecting or going to some other page. Any javascript you echo there should be able to refresh the parent (index.php or whatever opened the popup) and then close itself.

Infidel · June 2009

guar wrote: »

Maybe I'm not understanding, but to illustrate:

delete.php

<?php
    header('Location: http://localhost/index.php');

    $link = mysql_connect('localhost', 'root', '******');
    $db = mysql_select_db('backlog');

    $table = sprintf("%s", mysql_real_escape_string($_GET[table]));
    $id = sprintf("%s", mysql_real_escape_string($_GET[id]));;

    mysql_query("DELETE FROM $table WHERE id = $id");

    mysql_close($link);
?>

Oh god, why is your table a variable?? :lol:

Also, there sprintf's are totally doing nothing.

$id = intval($_GET['id']);

mysql_query("DELETE FROM mytable WHERE id = $id");

Also, I recommend putting the redirect as the last line, after processing. As mentioned by another earlier, you should do all your processing, then do your output. In this case, your output is simply the redirect header.

xzzy · June 2009

Putting the redirect at the bottom also means you'll see errors in the web browser, which is helpful for testing.

guar · June 2009

Infidel wrote: »

guar wrote: »

Maybe I'm not understanding, but to illustrate:

delete.php

<?php
    header('Location: http://localhost/index.php');

    $link = mysql_connect('localhost', 'root', '******');
    $db = mysql_select_db('backlog');

    $table = sprintf("%s", mysql_real_escape_string($_GET[table]));
    $id = sprintf("%s", mysql_real_escape_string($_GET[id]));;

    mysql_query("DELETE FROM $table WHERE id = $id");

    mysql_close($link);
?>

Oh god, why is your table a variable?? :lol:

Table, aka system name. I need to pass it to identify which table is being modified.

Also, I recommend putting the redirect as the last line, after processing. As mentioned by another earlier, you should do all your processing, then do your output. In this case, your output is simply the redirect header.

I ask because I'm getting the "cannot modify header information" error. Regardless of where I place that line in the file.

Infidel · June 2009

guar wrote: »

Infidel wrote: »

Oh god, why is your table a variable?? :lol:

Table, aka system name. I need to pass it to identify which table is being modified.

You'll want to rethink your database design then.

You shouldn't be allowing arbitrary tables to be deleted from, and you shouldn't have a table for each system but simply one table for them all.

guar wrote: »

I ask because I'm getting the "cannot modify header information" error. Regardless of where I place that line in the file.

Make sure you don't have a space or anything before your opening <? in the file.

guar · June 2009

I think I know what the problem is. My files are encoded as UTF-8; know a workaround that doesn't involve changing the encoding?

ed: Nevermind, figured it out. Set notepad++ UTF-8 encoding to without BOM, which seemed to fix it.

Penny Arcade

[HTML/PHP] Pop-ups & forms

Posts