I made a quick security update. If you own\administer your own phpBB board, I advise you do the same
[quote=psoTFX]Open viewtopic.php in any text editor. Find the following section of code:
//
// Was a highlight request part of the URI?
//
$highlight_match = $highlight = '';
if (isset($HTTP_GET_VARS['highlight']))
{
// Split words and phrases
$words = explode(' ', trim(htmlspecialchars(urldecode($HTTP_GET_VARS['highlight']))));
for($i = 0; $i < sizeof($words); $i++)
{
and replace with:
//
// Was a highlight request part of the URI?
//
$highlight_match = $highlight = '';
if (isset($HTTP_GET_VARS['highlight']))
{
// Split words and phrases
$words = explode(' ', trim(htmlspecialchars($HTTP_GET_VARS['highlight'])));
for($i = 0; $i < sizeof($words); $i++)
{
It is, I actually disabled highlighting for a few days while the phpBB group learned that this was indeed a security issue. There should be 3 more they patch with their upcomming version (2.0.11) if Im counting correctly. If they dont release 2.0.11 by Thanksgiving, PM me and I will give you some of my patches.
Marty: The future, it's where you're going? Doc: That's right, twenty five years into the future. I've always dreamed on seeing the future, looking beyond my years, seeing the progress of mankind. I'll also be able to see who wins the next twenty-five world series.
What is it...something to do with the word highlight thing when you're viewing a thread that works when you do a search...so a word split does what? Something to do with testing each word to see if it matches the word you've told it to highlight presumably. Right? What made that a security issue before?
alpha when you said in that other thread that you wont be adding new features..
... did you mean until after the "january" upgrade? or ever?
After the January upgrade.
I think what Deusfaux is trying to say is that he doesn't understand the difference between "new features" and "security patches".
Ah. Security patches to me are things that jeapordize the security of the Penny Arcade main website, and thus need to be fixed. New features are things that are nice to have, but if they didn't happen it wouldn't be the end of the world.
alpha when you said in that other thread that you wont be adding new features..
... did you mean until after the "january" upgrade? or ever?
After the January upgrade.
I think what Deusfaux is trying to say is that he doesn't understand the difference between "new features" and "security patches".
Ah. Security patches to me are things that jeapordize the security of the Penny Arcade main website, and thus need to be fixed. New features are things that are nice to have, but if they didn't happen it wouldn't be the end of the world.
I don't think the forums crashing would be the end of the world. :P
Also, you never did answer my question as to how this is a security flaw. I must be having a stupid moment cuz I'm sure it's really easy to figure out. If it's sooper seekrit, would you mind PM/IMing me rather than making it public.
I don't think the forums crashing would be the end of the world. :P
Also, you never did answer my question as to how this is a security flaw. I must be having a stupid moment cuz I'm sure it's really easy to figure out. If it's sooper seekrit, would you mind PM/IMing me rather than making it public.
Thanks.
Done.
Its not the forums I worry about, it is the main site. We share the same uid as far as PHP is concerned, you can see where that leads. I'll IM you.
What kind of things does this keep people from doing?
I don't know what an injection attack is unless we're talking like implanting alien eggs in the site or something
Injection attacks in the general sence mean that you are able to "inject" some code somewhere you shouldn't.
A classic example would be if someone doesn't check a username properly before putting it into the database. This can then allow someone to change the query to change the database, such as by giving them admin rites.
Injection attacks can happen anywhere you use a user suppled sting in a way that it can be executed. SQL injections (like the one described above) are probably the most common, but in some situations it's also possible to have insertion attacks that affect html or even have code executed on the command line.
Besides, the forum code is "semi frozen," meaning I wont be adding new features, only bug fixes.
So I asked if that held for just until after the Jan upgrade or ever, or when. Alpha answered it in exactly the way it asked. Dont know why you felt you needed to get involved. Don't pretend "to be nice".
What kind of things does this keep people from doing?
I don't know what an injection attack is unless we're talking like implanting alien eggs in the site or something
Injection attacks in the general sence mean that you are able to "inject" some code somewhere you shouldn't.
A classic example would be if someone doesn't check a username properly before putting it into the database. This can then allow someone to change the query to change the database, such as by giving them admin rites.
Injection attacks can happen anywhere you use a user suppled sting in a way that it can be executed. SQL injections (like the one described above) are probably the most common, but in some situations it's also possible to have insertion attacks that affect html or even have code executed on the command line.
Actually, the highlighting one was a code execution vulnerability, atleast as far as I understand it. And Orthanc described it better than I could have.
Thats enough of that. If you and Pheezer have something you need to take care of, please do it privately.
sorry, that was built up from reading snide comment after comment aimed at myself from him, here in Monkey Den. i will go back to ignoring them, and hope he gives it up.
looking forward to january and thereafter though :^:
This doesn't have anything to do with that Font Size/Font Color highlighting bug, does it?
Paladin on
Marty: The future, it's where you're going? Doc: That's right, twenty five years into the future. I've always dreamed on seeing the future, looking beyond my years, seeing the progress of mankind. I'll also be able to see who wins the next twenty-five world series.
This doesn't have anything to do with that Font Size/Font Color highlighting bug, does it?
No, it has to do with searching.
I really miss the bug forum ((((
Paladin on
Marty: The future, it's where you're going? Doc: That's right, twenty five years into the future. I've always dreamed on seeing the future, looking beyond my years, seeing the progress of mankind. I'll also be able to see who wins the next twenty-five world series.
Posts
I didnt know about this one Thats nasty.
More about hashes please!
we also talk about other random shit and clown upon each other
Doc: That's right, twenty five years into the future. I've always dreamed on seeing the future, looking beyond my years, seeing the progress of mankind. I'll also be able to see who wins the next twenty-five world series.
OH NOES!
Yeah, I know nothing about php.
... did you mean until after the "january" upgrade? or ever?
similar to split, but without the regex
I don't understand Maori either.
What is it...something to do with the word highlight thing when you're viewing a thread that works when you do a search...so a word split does what? Something to do with testing each word to see if it matches the word you've told it to highlight presumably. Right? What made that a security issue before?
I think what Deusfaux is trying to say is that he doesn't understand the difference between "new features" and "security patches".
CUZ THERE'S SOMETHING IN THE MIDDLE AND IT'S GIVING ME A RASH
I don't think the forums crashing would be the end of the world. :P
Also, you never did answer my question as to how this is a security flaw. I must be having a stupid moment cuz I'm sure it's really easy to figure out. If it's sooper seekrit, would you mind PM/IMing me rather than making it public.
Thanks.
Its not the forums I worry about, it is the main site. We share the same uid as far as PHP is concerned, you can see where that leads. I'll IM you.
http://secunia.com/advisories/13239/
I don't know what an injection attack is unless we're talking like implanting alien eggs in the site or something
Injection attacks in the general sence mean that you are able to "inject" some code somewhere you shouldn't.
A classic example would be if someone doesn't check a username properly before putting it into the database. This can then allow someone to change the query to change the database, such as by giving them admin rites.
Injection attacks can happen anywhere you use a user suppled sting in a way that it can be executed. SQL injections (like the one described above) are probably the most common, but in some situations it's also possible to have insertion attacks that affect html or even have code executed on the command line.
I think I meant exactly what I asked, dumbshit:
So I asked if that held for just until after the Jan upgrade or ever, or when. Alpha answered it in exactly the way it asked. Dont know why you felt you needed to get involved. Don't pretend "to be nice".
sorry, that was built up from reading snide comment after comment aimed at myself from him, here in Monkey Den. i will go back to ignoring them, and hope he gives it up.
looking forward to january and thereafter though :^:
Doc: That's right, twenty five years into the future. I've always dreamed on seeing the future, looking beyond my years, seeing the progress of mankind. I'll also be able to see who wins the next twenty-five world series.
Doc: That's right, twenty five years into the future. I've always dreamed on seeing the future, looking beyond my years, seeing the progress of mankind. I'll also be able to see who wins the next twenty-five world series.